varnish-cache icon indicating copy to clipboard operation
varnish-cache copied to clipboard

ESI onerror="abort" handling for OC_F_FAILED

Open nigoroll opened this issue 2 years ago • 1 comments

noticed en passant : We should probably also abort for this case

https://github.com/varnishcache/varnish-cache/blob/903611966b88aa464d22a9867411f31790b505f9/bin/varnishd/cache/cache_esi_deliver.c#L900-L904

nigoroll avatar Jun 12 '23 18:06 nigoroll

Noted as part of discussion: ESI spec says

»If an ESI Processor can fetch neither the src nor the alt, it returns a HTTP status code greater than 400 with an error message, unless the onerror attribute is present.«

bsdphk avatar Jun 19 '23 14:06 bsdphk