Nils Goroll

cache_ban: Forward compatibility for the binary ban representation

2

Our ban expressions (like `obj.age > 20s`) are represented in a binary format (see [top of `cache_ban.h`](https://github.com/varnishcache/varnish-cache/blob/6d5aa36cc13f0d09211ffa74e68d7ca607d921d2/bin/varnishd/cache/cache_ban.h#L31-L56)) which allows for forward compatibility, yet at the respective places we currently just...

param: Add shutdown_timeout

2

Similar to why we added `startup_timeout`, orderly shutdown of a varnishd worker process might take considerably longer than cli_timeout. Consequently, we add `shutdown_timeout`.

SIGSEGV in vmod bad metadata code path

2

### Expected Behavior varnishd should drop an error message if loading a vmod/extension fails ### Current Behavior vcc crashes ``` Error: Message from VCC-compiler: FOUND VMOD in VEXT ../vext_cache/libvmod_slash.so,yoaekqrm.so Running...

cache_req_fsm: keep the cache object's Content-Length for HEAD always

9

Previously, we would only keep the Content-Length header for HEAD requests on hit-for-miss objects, now we simply keep it always to enable "fallback" caching of HEAD requests. The added vtc...

Magic 0.5 second HTC_RxStuff() timeout in h2_rxframe()

4

There is a seemingly _magic_ `0.5` seconds timeout here, added in 41ef373af53571a94ea8f73f0538322270799a84. @dridi can you please help my understand why it has this particular value? https://github.com/varnishcache/varnish-cache/blob/37a8bebf0f7fb0a68af9669af57ff094b8114ee0/bin/varnishd/http2/cache_http2_proto.c#L1480-L1481 edit: I had been...

from today's bugwash discussing #4284: We should probably count H2 status codes

https://github.com/varnishcache/varnish-cache/blob/a62cb553d3a535c9d13a423c8f3d01366261ab1a/bin/varnishd/cache/cache_ban.c#L550 When loading a persistent storage from a later version which has a new ban format on an older version, a panic is triggered: ``` Wrong turn at cache/cache_ban.c:550: Wrong...

In the context of #4284 I read rfc9113 again, cross-checking with our code, and I now think that our [`GOAWAY`](https://datatracker.ietf.org/doc/html/rfc9113#name-goaway) handling is incomplete to wrong. ### We have a single...

Unify workspace overflow reporting

1

### Expected Behavior Make it simple to find workspace overflows ### Current Behavior If I am not mistaking (and I probably am overlooking something), one currently needs a monster like...

WIP more WS_Overflowed() checks

2

Re #4232 Adding earlier overflow checks is pretty easy if we use VCL failure, but so far we had centralized the overflow handling on the client side in the `vtr_deliver_f`,...