Niels Basjes
Niels Basjes
I had a look at this Filters feature and (although I do not yet fully understand how it should work) it seems like a generic solution to handle variation in...
@michael-o I have pulled the fix for the MSHADE-340 test to this separate merge request. Related to https://github.com/apache/maven-shade-plugin/pull/26 and https://github.com/apache/maven/pull/483
Yes, normally I fully agree. However in my opinion this fix is useless/meaningless without MSHADE-36 fix I created. That is why I chose to make this a commit on top...
I've updated https://github.com/apache/maven-shade-plugin/pull/25 to be a single commit as requested. Because these two changes are dependent this pull request will look like 'two commits' but it is actually a single...
FYI: I did some additional testing in my own project and these changes work as I expect them to work. See: https://github.com/nielsbasjes/yauaa/tree/VerifyMSHADE36-MSHADE326
@elharo I would like to see this problem fixed. If there is anything I need to change then I'm happy to do that. Just say what the desired solution is.
@michael-o I rebased the code. Moved the tests to the right place. Checked the review comments and applied similar changes (like the `@since 3.3.0`) . Applied formatting to the javadoc....
@michael-o I'm trying to see what happens. Will report here what I find.
@michael-o @rfscholte [Sorry, earlier I got it wrong. So I edited this comment] What I think you meant: If this hack in maven is removed the test I created for...