Niels Basjes

Results 127 comments of Niels Basjes

I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of this "plugin...

> > I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of...

> > The Conventional Commits part has specific configuration. That "next version calculator" is a plugin for the maven-release plugin. > > I know see, it is not a plugin...

> There is an option to inject an `Xpp3Dom` object into the plugin config which in turn could be passed to your class. Cool! Can you please point me towards...

I take the clean master branch and only change in the main pom.xml ``` - 1.13.0 + 2.0.0-M2-SNAPSHOT ``` Then I run `mvn clean verify` (without the -Prun-its !!) Then...

I checkout the master twice and did some debugging with both settings. So far I have tracked the `expected: but was:` down to the DefaultScmRepositoryConfigurator being constructed (`@Inject`) with two...

At this point my guess (I do not fully understand many of the details of the injection system used here) is that the root cause is related to some of...

> Good question. I don't know an example from the top of my head, but you can search `maven-sources` multirepo for `Xpp3Dom`. I am sure this will do. In Maven...

How shall we proceed? Commit the way it is now (the config is an xml within a cdata block) or wait till the config has been changed to the way...

@michael-o - I have updated this by rebasing it on top of https://github.com/apache/maven-release/tree/maven-scm-2.0.0 - The `mvn -Prun-its clean verify` works on my machine (running on JDK 17). I'm still trying...