Niels Basjes

icon indicating a website link https://niels.basjes.nl

icon company @bolcom icon location Amstelveen, NL icon location Principal IT Architect/Inventor at @bolcom . Committer and PMC for @apache Avro. Contributor for many of the @apache "BigData" projects.

Results 127 comments of Niels Basjes

[SCM-939] Towards JUnit4 ... DRAFT !!

Thanks @michael-o !

Yahoo Link Preview

Looks good to me.

fix: Suppress this-escape warning in generated Parser introduced in JDK 21

@parrt FYI: The bug report https://github.com/antlr/antlr4/issues/4341 was only partially fixed by https://github.com/antlr/antlr4/pull/4394 . This pull request fixes the missing part for that issue.

fix: Suppress this-escape warning in generated Parser introduced in JDK 21

Gentle ping to @parrt, this is ready for review.

[Java] Generated code gives "this escape" warning on Java 21 in Parser class

Additional reproduction: Take the reproduction of https://github.com/antlr/antlr4/issues/4341 located here https://github.com/khmarbaise/issue-antlr-4.13.0 Clone this and change the version to 4.13.1 When you actually build this with Java 21 you'll see that the...

TODO: Remove Antlr4 - Java 21 workaround

This is the code: https://github.com/nielsbasjes/yauaa/blob/main/analyzer/pom.xml#L419-L434 A scripted search and replace to fix this issue in the code generated by Antlr

TODO: Remove Antlr4 - Java 21 workaround

Done

[Feature Request]: Reading blocks of registers

[modbus-sunspec.zip](https://github.com/apache/plc4x/files/10420712/modbus-sunspec.zip)

[Feature Request]: Reading blocks of registers

For me this is not seen as a bug in your library but as a peculiar response of a real life system. Ill double check if your newer implementation changes...

[Feature Request]: Reading blocks of registers

Also; I realized a while ago that the only way any library can reliable read this device is when this library has a full schema of the device at hand....