Nick Rodriguez
Nick Rodriguez
Should this be a warning? While we know that node will probably throw when running whatever unsupported module type, we can't be 100% future proof with that. IMHO, it's a...
I'm assuming that the best way to implement that would be use tsc with a outFile param.
Is it possible that we could use tsc to compile to ESNext, and then use babel to transpile down if needed?
@nkrusch wanted to ping you to let you know about this
I'm going to commit a temporary fix to this, which will just be a reversion to chalk v4. At that point, I'll start work on a PR to use ESM...
@nkrusch I've gotten the master version stable. I won't be making any new commits to master for a while, so if you want to, now would be a great time...
What you're probably looking for is an end to end test. This can still be achieved with sinon. It'll probably take a while to get e2e tests running though.
> What do you guys think about supporting a `tsconfig.js` in addition to `tsconfig.json`? That way we would be free to build our own sharing / extending of configs through...
Thanks for that pointer! I'll take a look at those baselines and commit them (i might throw some questions in there if i have any i cant figure out).
Test failures aren't related to this change, they come from parse/v1.