extension-cli icon indicating copy to clipboard operation
extension-cli copied to clipboard

ACTION: chalk breaking change

Open nicolas377 opened this issue 3 years ago • 3 comments

About a month ago, I merged #134 into master, which was a breaking version of chalk. I hadn't properly tested the change, and it seems that chalk has changed directions to use ESM, and not support CommonJS. This can be demonstrated by using the current state of master (at commit 4684574c16afa04af4bc6b797d4837b5bfaae84d), and running npx extension-cli. You should see this error (unneeded dirs blacked out):

image

I'll be working on fixing this, but this will remain a tracking issue.

nicolas377 avatar Jan 17 '22 15:01 nicolas377

@nkrusch wanted to ping you to let you know about this

nicolas377 avatar Jan 17 '22 15:01 nicolas377

I'm going to commit a temporary fix to this, which will just be a reversion to chalk v4. At that point, I'll start work on a PR to use ESM (we may potentially need to use module bundling for that).

nicolas377 avatar Jan 17 '22 15:01 nicolas377

@nkrusch I've gotten the master version stable. I won't be making any new commits to master for a while, so if you want to, now would be a great time to do a patch release.

nicolas377 avatar Jan 17 '22 16:01 nicolas377