Nick Rodriguez

icon location South Carolina icon location I ask if you rebooted your computer and cleared your cache for a living.

Results 28 comments of Nick Rodriguez

feat(node): add promise typings to readline

There are two things that I think you're talking about: 1 would be adding `export` in the main typings of `node:readline`. Since readline re-exports the promise typings, to avoid a...

feat(node): add promise typings to readline

If blocking pr #61133 is gonna be held up for a bit, I'd like to move forward with code change reviews.

feat(node): add promise typings to readline

Rebased on top of master with the `no-const-enum` fixes.

feat(node): add promise typings to readline

Reverted lining changes and rebased on top of current master. @mcollina could you take a look at this again?

feat(node): add promise typings to readline

Ready to merge

[@types/chrome] Fix chrome.tabs.sendMessage()

IMHO, TS is kinda about best practices, and its definitely best practice to use MV3. But that's pretty irrelevant here, because if we did support MV2, we couldn't support MV3...

File is put in a dir with the same name of the file

I actually stopped using this action a while ago, so I'm not sure. I'll try replicating this again, and see what happens.

[node] Fix `http.createServer` signature

I've been summoned from my summer break grave, and oh boy did I just go on the tour of this repo. Looks like the original reason my package is breaking...

[node] Fix `http.createServer` signature

Thanks @jakebailey for fixing the ecosystem breaks, really appreciate it. I'm gonna recuse myself since this doesn't affect any of my packages anymore, but I'll keep the review up out...

Fix getCurrent API return type

Wait, I must have missed something my first time around. My reading now seems to imply that the undefined case ends with the Promise resolving with `undefined`, not the function...