SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add additional Room AC profiles

Open nickolas-deboom opened this issue 9 months ago • 3 comments

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This change adds additional Room AC profiles that exclude the thermostatOperatingState capability. Note that some other profiles are removed to stay under the limit of 100 profiles per driver.

Summary of Completed Tests

nickolas-deboom avatar Mar 21 '25 19:03 nickolas-deboom

Channel deleted.

github-actions[bot] avatar Mar 21 '25 19:03 github-actions[bot]

Test Results

   65 files    418 suites   0s ⏱️ 2 122 tests 2 122 ✅ 0 💤 0 ❌ 3 637 runs  3 637 ✅ 0 💤 0 ❌

Results for commit 1d55fb10.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 21 '25 19:03 github-actions[bot]

File Coverage
All files 85% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 86% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 50% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 1d55fb108b4ff7833dfe124d447725e9249a4877

github-actions[bot] avatar Mar 21 '25 19:03 github-actions[bot]

should we close this PR for simplicity?

hcarter-775 avatar Apr 14 '25 14:04 hcarter-775

Closing as no longer needed with profile limit increase.

nickolas-deboom avatar Apr 14 '25 14:04 nickolas-deboom