Nathan Zimmerberg

Results 150 comments of Nathan Zimmerberg

This should work with package compiler because the reading from the path won't happen at run time. Though you will also need to edit https://github.com/ASML-Labs/PPTX.jl/blob/64435fe29a9e50c366be5f8067f8e6b4199a8f30/src/write.jl#L144 and https://github.com/ASML-Labs/PPTX.jl/blob/64435fe29a9e50c366be5f8067f8e6b4199a8f30/src/write.jl#L70 to accept `Vector{UInt8}`

Yes, a package isn't relocatable if it uses a string path at runtime that was defined at compile time. One solution is to use https://github.com/JuliaPackaging/RelocatableFolders.jl or Artifacts to allow the...

@jakobnissen thank you for reviewing this. I'd also like to get this in 1.11

This is an important bug fix because the documentation in Julia 1.11 explicitly states that the `String` constructor will copy for all `AbstractVectors{UInt8}` except `Vector{UInt8}`.

Could the `ZSTD_CCtx_setPledgedSrcSize` function in https://facebook.github.io/zstd/zstd_manual.html#Chapter5 be used to set the frame size and also keep the streaming API? Also is there a reason for `ZstdFrameDecompressor`? IIUC the regular `ZstdDecompressor`...