julia icon indicating copy to clipboard operation
julia copied to clipboard
verified publisher icon JuliaLang

Make `String(::Memory)` copy

Open nhz2 opened this issue 1 year ago • 11 comments

A more targeted fix of #54369 than #54372

Preserves the performance improvements added in #53962 by creating a new internal _unsafe_takestring!(v::Memory{UInt8}) function that does what String(::Memory{UInt8}) used to do.

nhz2 avatar May 13 '24 23:05 nhz2

bump

nhz2 avatar Jun 16 '24 00:06 nhz2

bump

nhz2 avatar Jul 09 '24 13:07 nhz2

bump

nhz2 avatar Jul 18 '24 17:07 nhz2

bump

nhz2 avatar Jul 30 '24 00:07 nhz2

bump

nhz2 avatar Sep 09 '24 17:09 nhz2

@jakobnissen thank you for reviewing this. I'd also like to get this in 1.11

nhz2 avatar Sep 17 '24 21:09 nhz2

I think it would be ideal if we could get @vtjnash to review this before merging.

DilumAluthge avatar Sep 18 '24 00:09 DilumAluthge

@vtjnash Can you review this?

DilumAluthge avatar Sep 20 '24 22:09 DilumAluthge

Bump @vtjnash

DilumAluthge avatar Oct 08 '24 18:10 DilumAluthge

This is an important bug fix because the documentation in Julia 1.11 explicitly states that the String constructor will copy for all AbstractVectors{UInt8} except Vector{UInt8}.

nhz2 avatar Oct 10 '24 23:10 nhz2

Bump @vtjnash Can you review this?

DilumAluthge avatar Oct 10 '24 23:10 DilumAluthge