Nathan Zimmerberg

Here is an example where using the `String` constructor on a `Vector{UInt8}` can result in mutating a `String` ```julia io = IOBuffer() write(io, [0x61,0x62,0x63]) seekstart(io) a = read(io, 3) b...

Maybe `bytes2string` is a better name?

There is already a `transcode(::Type{String}, src)` function. https://github.com/JuliaLang/julia/blob/d01d2561e69822667a8d809064109cd46fba22c1/base/strings/cstring.jl#L179 Maybe this can be changed to avoid mutating the input.

`String(copy(v))` still makes two copies as noted in https://github.com/JuliaLang/julia/pull/26093#issuecomment-366809258 In ZipArchives.jl I would like to avoid the extra copy. This is currently possible with `unsafe_string`, so an extra function in...

Fixed by #54927

After a call to `unsafe_takestring(::Memory)` it is also unsafe to read from the memory because Julia can free the memory. For example, here is an example that leads to a...

The docs for `isdigit` states it only includes characters 0-9. > Tests whether a character is a decimal digit (0-9). ```julia julia> c = '４' '４': Unicode U+FF14 (category Nd:...

Yes, the docstring should be updated to be explicit about only including ASCII decimal digit then, but I have code that would break if this function returns true for other...

This got fixed for `iso_codes_jll` in https://github.com/JuliaPackaging/Yggdrasil/pull/7926 However, from what I can tell `Mousetrap` also depends on `libadwaita_jll`. This artifact contains the following symlinks as well. ``` "bin/gdk-pixbuf-pixdata" => "/usr/bin/gdk-pixbuf-pixdata"...

Because `ZipReader` works on `Vector{UInt8}` you could also bake in the data from the default template instead of using artifacts. ```julia include_dependency(joinpath(TEMPLATE_DIR, "no-slides.pptx")) include_dependency(joinpath(TEMPLATE_DIR, "tableStyles.xml")) const default_template_data = read(joinpath(TEMPLATE_DIR, "no-slides.pptx"))...