John Patrick

Results 127 comments of John Patrick

Covers same issue as previously raised in earlier PR https://github.com/geerlingguy/ansible-role-jenkins/pull/343

> Thank you for this fix @nhojpatrick. But seems like this is a duplicate of #343. You can close this PR since it's the same. @brootware #343 only fixes/solves Debian,...

> can you take a look at the tests? Happy too, I've no time until weekend probably but will be looking at them then. Wanted to get it raised and...

Fixing the same issue as highlighted here https://github.com/jenkinsci/docker/pull/1299

I've found time. To make testing easier I've added JUnit v5 and assertAll to all errors show. I've updated so if you define `JENKINS_UC_DOWNLOAD_URL` it's used for everything, so a...

Converting to draft and rebase from PR https://github.com/jenkinsci/plugin-installation-manager-tool/pull/417 so this PR easier to understand what has changed when using assertAll to improve dev/test cycles.

Fixing the same issue as highlighted here https://github.com/jenkinsci/docker/pull/1299

> I don't understand this change, this is exactly how it works after #375 . That code doesn't appear to fully work in all situations. Reading the code it looks...

@aleksandr-m any thoughts about this PR, like the maven wrapper detection PR. It defines the variables the parent process automatically detected for `-gs` or `-s`, but if they are specified...

@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that.