gitflow-maven-plugin icon indicating copy to clipboard operation
gitflow-maven-plugin copied to clipboard

Take 2 Global Settings and User Settings

Open nhojpatrick opened this issue 5 years ago • 4 comments

Another approach to https://github.com/aleksandr-m/gitflow-maven-plugin/pull/244

Adding gitflow.maven.settings.global and gitflow.maven.settings.user as plugin properties.

If -gs is already in the argLine it is skipped, same handling for -s.

nhojpatrick avatar Aug 18 '20 08:08 nhojpatrick

@aleksandr-m any thoughts about this PR, like the maven wrapper detection PR. It defines the variables the parent process automatically detected for -gs or -s, but if they are specified they are skipped. And if they are defined as a property those are used instead.

nhojpatrick avatar Jan 17 '21 19:01 nhojpatrick

@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that.

nhojpatrick avatar Mar 18 '21 18:03 nhojpatrick

@aleksandr-m can this also be review and hopefully merged please. This and the other would result vm config and extra pom config.

nhojpatrick avatar Sep 09 '21 07:09 nhojpatrick

+1, i hit the same problem when developing the ITs for #323

stefanseifert avatar Jan 04 '22 20:01 stefanseifert