plugin-installation-manager-tool icon indicating copy to clipboard operation
plugin-installation-manager-tool copied to clipboard

Use JENKINS_UC_DOWNLOAD_URL if provided

Open nhojpatrick opened this issue 3 years ago • 5 comments

Fixes https://github.com/jenkinsci/plugin-installation-manager-tool/issues/415

The current code ignores JENKINS_UC_DOWNLOAD_URL if specified, as logic above will always result in something else being checked. Other if/else statements might also need to be changed to fix other issues with that logic.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

nhojpatrick avatar Mar 10 '22 13:03 nhojpatrick

can you take a look at the tests?

timja avatar Mar 10 '22 13:03 timja

can you take a look at the tests?

Happy too, I've no time until weekend probably but will be looking at them then. Wanted to get it raised and review then fix tests.

nhojpatrick avatar Mar 10 '22 13:03 nhojpatrick

Fixing the same issue as highlighted here https://github.com/jenkinsci/docker/pull/1299

nhojpatrick avatar Mar 10 '22 13:03 nhojpatrick

I've found time. To make testing easier I've added JUnit v5 and assertAll to all errors show. I've updated so if you define JENKINS_UC_DOWNLOAD_URL it's used for everything, so a true global override.

nhojpatrick avatar Mar 10 '22 21:03 nhojpatrick

Converting to draft and rebase from PR https://github.com/jenkinsci/plugin-installation-manager-tool/pull/417 so this PR easier to understand what has changed when using assertAll to improve dev/test cycles.

nhojpatrick avatar Mar 11 '22 08:03 nhojpatrick