Nahid Ferdous Mohit
Nahid Ferdous Mohit
Thank you for the review, @techanvil! @wpdarren That would be fab! I'm already working on #5276 and I have already included the fixes there. Thank you!
@techanvil I've updated the component path according to the blocking issue's IB. Thank you!
> The IB here looks good, but instead of calling the method inside `Modules.php`, we can probably just name it `delete_dashboard_sharing_settings`. We aren't really "resetting" anything—it's just that removing the...
@tofumatt I've updated the IB and the PoC PR to reflect on the suggestions. In order to not over-crowd `assets/js/components/dashboard-sharing/DashboardSharingSettingsButton.js`, I decided to create a new component `DashboardSharingDialog` which would...
That completely makes sense and thank you so very much for the kind explanation of what's wrong with the IB here. I'll definitely keep them in mind for future IBs...
@tofumatt I have a question regarding the placement of the `Reset sharing settings` action in the dialog. If we place it according to the mockup image in the issue description,...
Thank you for the insights, @tofumatt! > If it's possible to move the "Reset sharing permissions" to the left on the notice but ONLY on non-mobile viewports: let's do that....
Thank you for chiming in with the confirmations, @tofumatt! > Position of 'Reset sharing settings' action in the dialog along with notices not look good and it also gets cut...
@mohitwp We've decided to remove the `Reset sharing permissions` action when there is a notice/error visible. This change is added to my new PR.
Great catch, @felixarntz! Thank you for addressing this in my absence, @eugene-manuilov!