Nahid Ferdous Mohit
Nahid Ferdous Mohit
Thank you very much for the feedback, @techanvil!
@aaemnnosttv @asvinb @eugene-manuilov Does this issue still actually exist? I tried to replicate it following the replication steps but couldn't. Also, it looks like this error message no longer exists...
> Thanks, @nfmohit. Good work. Added a few comments, please, take a look. Thank you for the kind review, @eugene-manuilov! I've addressed the changes.
> @nfmohit, the is_ssl function exists from WP 2.6.0, there is no need to add a backward compatibility for it, we can use that function as is. @eugene-manuilov The `...
Thank you @eugene-manuilov! I have updated the IB.
### QA:Eng Verified ✅ - Built the plugin in development mode with `npm run build:dev`. - The TwG module still shows up in non-https sites. ie. `http://sitekit.10uplabs.com/`
> - In `assets/js/components/settings/SettingsActiveModule/Header.js`, modify the following: > * The main `Link` component should be replaced with a `div` element. > * Fix the lint and accessibility errors for the...
@wpdarren @mohitwp Thank you for checking. The behaviour that you're seeing is correct. The Figma design that @mohitwp referenced to actually gets accomplished in #5621. "Connect Google Analytics 4" should...
@felixarntz I noticed it post merge (should've noticed earlier, my bad, apologies) and included a fix for it in #5803 (#5621). I can create a new PR addressing only this...
@felixarntz Understood. Added a new PR targeting `main`. Thank you!