Nahid Ferdous Mohit
Nahid Ferdous Mohit
I have updated the IB according to the above suggestions, thank you @aaemnnosttv! I have a small follow-up question if that's okay: > We can use [wp_remote_retrieve_response_code](https://developer.wordpress.org/reference/functions/wp_remote_retrieve_response_code/) for getting the...
Updated the IB, thank you, @aaemnnosttv!
> **Question** - In AC it is mentioned that `pass should be true if the request returns a status code < 400`. I verified response status code is 200 which...
> Additionally, the padding/margins seem off, there's more padding once the "Set up now" button is clicked. This existed in `develop` and has been fixed by #5276. I've merged `develop`...
Thank you so much for pointing that out, @tofumatt! In the screen where the user gets to select a property (i.e. a measurement ID has been created and is available),...
Thank you so much for clearing this, @tofumatt! I did some more thorough reading and observation of the Design Docs and the Figma designs, and I think if there are...
Thank you for the confirmation, @techanvil! I have updated the PR to go to the SuccessBanner after a successful submission.
> Looks good @nfmohit, I just have one small suggestion and this should be good to go. I've updated it, thank you @techanvil!
I've addressed the suggestions. Thank you, @techanvil!
Thank you for your findings, @wpdarren! For issues 1 & 2, the implemented font sizes reflect the GM2+ styles in order to keep them consistent with the other Banner Notifications....