Nate Fischer

icon indicating a website link https://nfischer.github.io/

icon company @google icon location Mountain View, California icon location @google engineer working on Chromium and Android WebView. @shelljs lead dev

Results 340 comments of Nate Fischer

Data loss. shell.cp() Content of file is erased when trying to copy it to the folder it already belongs to

Thanks for confirming. I adjusted the title to remove the word "regression."

Preserve colors in output of exec()

Thanks, @sedwards2009! We would unfortunately need to find some sort of Windows equivalent before we could use that, but that's a good start :+1:

Preserve colors in output of exec()

@TossShinHwa take a look at #524 and let me know if it preserves colors/spinners

Preserve colors in output of exec()

This is an explicit goal of #866. I encourage you to review https://shelljs.page.link/cmd-design#heading=h.xf8zudcsg483 (specific section: "Step 3: real-time output mode")

Preserve colors in output of exec()

I believe color output is a potential outcome of that design. I haven't implemented that part of the design yet, but I'll update this issue when I do.

Unable to copy folder content from network folder

Sounds like the glob expansion is failing for the network drive. This is probably an issue specific to how Windows works, since it sounds like it's not returning the directory...

XDOTool not working with ShellJS

What is `xdotool`? Can you link to documentation for this tool and explain how I can install it for testing?

using shelljs in a JS Module is broken.

I think you want `import shell from 'shelljs';`. Here's an example (which is transpiled by babel, but hopefully still works with native ES module support): https://github.com/shelljs/shx/blob/61aca968cd7afc712ca61a4fc4ec3201e3770dc7/src/shx.js#L1 Let me know if...

using shelljs in a JS Module is broken.

Just tried this out and it seems to work for me: ```js // index.mjs import shell from 'shelljs'; console.log(shell.ls().stdout); ``` I can run this with: ```sh $ node --version v16.13.1...

Consider switching to fast-glob for performance

Another related package: [sindresorhus/globby](https://github.com/sindresorhus/globby) (fast-glob under the hood, with a nicer API and good support for async-await down the road).