Nate Fischer comments

Results 340 comments of


                                            Nate Fischer

How to pass options or use callbacks?

I don't think I ever provided support for these, but these are great feature requests. --- > ``` > shell.curl('google.com', {silent:true}); > ``` You can get the same behavior with...

Add a popup to the UI

:+1:

chore(ci): bump CI to include node v15/16

Closing in favor of https://github.com/shelljs/shelljs/pull/1099

[cp] Add test for cycle symlink

Could you rebase? I recently updated CI to use GitHub actions instead. This may be more reliable than the old environment.

[cp] Add test for cycle symlink

Thanks for trying the rebase. Looks like the error message from https://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true is: ``` cp » Test with cycle symlink D:\a\shelljs\shelljs\tmp04812076144037267068[653](https://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true#step:5:653)06818777819\test\cp.js:635 Value is not falsy: 'cp: cannot create directory \'new\':...

Report forgotten errors from 'mv'

@vgalka-sl any update on this issue? Let me know if I can clarify anything.

refactor(mkdir): consistent error handling

@freitagbr take a look, but this should probably be considered as a breaking change because it changes error messages.

Add tests for rm removing symlinks

@freitagbr what state is this in?

Add tests for rm removing symlinks

@freitagbr 2 tests fail on Windows, it looks like we should skip them.

Allow ln destination to be an existing directory, fixes #832

> Regaring the other ln() issues: I'd be glad to go for those if they're similarly low-hanging fruit as this one was. I'll take a look tomorrow. I think #829...