Nate Fischer

Results 340 comments of Nate Fischer

@Loilo just checking in. I think this is basically good if we revert c57f7ffc3ffb8ab828b9032ce6effb477dc5cc30 (to limit the fix to #832). You can cherry-pick that commit to a new branch and...

@Loilo are you interested in continuing this? Otherwise, I'll take this over and merge the fix for #832.

@Loilo no worries, I'll just cherry pick your commits for #832. Feel free to revisit a fix for #829 when you're back.

Unix `cp` also hangs though, so this isn't the bug. I do see a difference in behavior: ```sh $ cp my_fifo some_file & $ echo 'hi' > my_fifo # now...

@bruce-one are we confident that `isFIFO()` always returns `false` for Windows, or is this something we need to investigate? I'm hesitant to add features that go untested on Windows--if there's...

> Another outstanding question with this is in the recursive type scenario: should we call mkfifo or something to create the fifo to better replicate cp? (afaict, node can't do...

@bruce-one thanks for following up on this > Unfortunately creating character and block devices requires root permissions... I would like to steer clear of root-only features in ShellJS core. After...

> One of the reasons I ask that is because a "shelljs/plugin-posix" could be useful (from past experience) because I know I personally use shelljs solely on posix-like OSs, and...

Since this seems to be a regression, can you try the same code on earlier ShellJS versions? Can you try 0.7.7 or higher (but **before** 0.8.0)? That appears to be...