Nate Fischer comments

Results 340 comments of


                                            Nate Fischer

Refactor ShellString into a real class

Can't you also do it via `ShellString.prototype`? That's how someone would modify the `ShellString` class anyway (this is an intended part of the plugin API).

Refactor ShellString into a real class

Bumping to v0.9 milestone

Refactor ShellString into a real class

> TypeError: s.foo is not a function (**on node v4, not v6**) Sounds like this is easier to fix when we drop v4 (#873). Let's postpone until then.

Refactor ShellString into a real class

> would you be open to me sending some PR that modernizes this a bit? I would be open as long as it runs in node v8 without transpiling. If...

shell.exec doesn't return columns names with some shell commands

This is probably because `flatpak list` has different behavior depending on whether it is writing to a TTY (like a terminal) or something else (like a file, or in this...

shell.exec is not working with protractor framework

Can you tell me a little about what protractor is? Can you include any error output from the `shell.exec()` invocation?

Shelljs exec does not capture output from snap programs

Can you confirm this really is snap-specific, and not a quirk of the kotlin command itself? It may be possible it's changing its behavior based on whether it's attached to...

Shelljs exec does not capture output from snap programs

What happens if you use `child_process.execSync()` instead of `shell.exec()`? Same results?

mv silently swallows errors

Thanks for reporting this. Confirmed this happens on unix too (via `shx v0.3.1 (using ShellJS v0.8.2)`)

exec not returning exit code properly

If I understand correctly, you're trying to implement bash's behavior by exiting the script with the error code of the last shelljs command. > Shouldn't this be the default behavior?...