Alex Martens

Results 215 comments of Alex Martens

Continuous timers are part of the `PwmPin` traits: https://github.com/stm32-rs/stm32wlxx-hal/blob/a9d4b5a77d7d4fc6d5da3402328196d980d4b680/hal/src/lptim/mod.rs#L767 There's an example here: https://docs.rs/stm32wlxx-hal/latest/stm32wlxx_hal/lptim/trait.LpTim.html#example-5 The `new_output_pin` method is optional, that's just for PWM.

No problem! It is misleading being called `PwmPin` when the pin isn't even required :sweat_smile:

I gave it a quick skim, it looks like the SysTick is simply used to calculate the speed of the encoder: [stm32f1xx_it.c#L197](https://github.com/controllerstech/STM32/blob/034758ed85bfca74d367c31dec64c32939faecf3/TIMER%20ENCODER%20MODE/stm32f1xx_it.c#L197) The actual position comes from a different mechanism,...

`exception` has a special meaning for Cortex-M CPUs. Some exceptions are used for error status', but more generally they are just built-in interrupts. This is the exception number definition for...

> Perhaps we can change the function to `fn channel(&self)` but it might break some assumptions. That is one of the changes coming in the 1.0.0 release of embedded-hal: https://docs.rs/embedded-hal/1.0.0-alpha.7/embedded_hal/adc/nb/trait.Channel.html...

Alternatively put a bool into the readers/writers and add a debug assertion in `drop`.

Going to wait for https://github.com/knurling-rs/defmt/pull/805

My biggest concern with that is maintenance of the `no-std-net` dependency, it appears to be maintained by just @dunmatt. I really like that the `embedded-nal` is under a project with...

@eldruin would you be able to give @dunmatt a `no-std-net` repository in the rust embedded community, to complement the `embedded-nal`? Not sure if there is an RFC process or anything...

The RFC for networking types in `core` got merged, looks like it won't take much longer for implementation.