[Suggestion] Add embedded-nal implementation
Hi,
This crate looks awesome!
Just in case you did not know it existed, i wanted to share https://github.com/rust-embedded-community/embedded-nal/ as i think it could benefit the adoption of this crate over all, as it makes it drop-in replaceable with all the other crates/devices requiring embedded-nal
My biggest concern with that is maintenance of the no-std-net dependency, it appears to be maintained by just @dunmatt.
I really like that the embedded-nal is under a project with multiple owners, allowing it to live on beyond any one maintainer.
Do you think we could move no-std-net under the embedded-community banner as well (@dunmatt)?
There are some optional features in the networking types here that I would be interested in adding to that as well:
- Formatting with
defmt(e.g. https://github.com/newAM/w5500-ll-rs/blob/main/src/net.rs#L263) - Conversion to/from
std::nettypes (e.g. https://github.com/newAM/w5500-ll-rs/blob/main/src/net.rs#L303)
...on a related topic, is there an RFC process for adding a crate to the rust embedded community?
I would really like add a standalone no_std EUI-48 and EUI-64 crate somewhere.
That definitely sounds like progress, I'm in, what do you need from me?
On Fri, Feb 26, 2021, 08:42 Alex [email protected] wrote:
My biggest concern with that is maintenance of the no-std-net dependency, it appears to be maintained by just @dunmatt https://github.com/dunmatt.
I really like that the embedded-nal is under a project with multiple owners, allowing it to live on beyond any one maintainer.
Do you think we could move no-std-net under the embedded-community banner as well (@dunmatt https://github.com/dunmatt)?
There are some optional features in the networking types here that I would be interested in adding to that as well:
- Formatting with defmt (e.g. https://github.com/newAM/w5500-ll-rs/blob/main/src/net.rs#L263)
- Conversion to/from std::net types (e.g. https://github.com/newAM/w5500-ll-rs/blob/main/src/net.rs#L303)
...on a related topic, is there an RFC process for adding a crate to the rust embedded community? I would really like add a standalone no_std EUI-48 and EUI-64 crate somewhere.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/newAM/w5500-hl-rs/issues/14#issuecomment-786724017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIN7S7RO3T3CDU2WEPJE4TTA66OFANCNFSM4YH7DYQQ .
@eldruin would you be able to give @dunmatt a no-std-net repository in the rust embedded community, to complement the embedded-nal? Not sure if there is an RFC process or anything more formal that needs to be done here.
(Sorry if I got the wrong person, it looks like @eldruin has access to make new repos on the rust-embedded community.)
I would agree to that. There are two ways to proceed:
- I think what would make most sense would be for @dunmatt to join the r-e-c org and transfer the repository.
- We create a fork inside the r-e-c and give @dunnmatt rights on that fork.
@dunmatt If you are interested in this, please open an issue in the meta repository.
Please note that the r-e-c will soon be renamed rust-embedded-unofficial once I find some time, in case the name is relevant for your decision.
Sorry for the delay, it got buried, but yeah, I'll open an issue
On Sun, Feb 28, 2021 at 3:26 AM Diego Barrios Romero < @.***> wrote:
I would agree to that. There are two ways to proceed:
- I think what would make most sense would be for @dunmatt https://github.com/dunmatt to join the r-e-c org and transfer the repository.
- We create a fork inside the r-e-c and give @dunnmatt rights on that fork.
@dunmatt https://github.com/dunmatt If you are interested in this, please open an issue in the meta https://github.com/rust-embedded-community/meta/issues repository.
Please note that the r-e-c will soon be renamed rust-embedded-unofficial once I find some time, in case the name is relevant for your decision.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/newAM/w5500-hl-rs/issues/14#issuecomment-787429687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIN7S3XQZBCAGY6LAFFKE3TBIK5NANCNFSM4YH7DYQQ .
It has been quiet, I guess concern with no-std-net is not yet solved?
Oh snap, sorry, it slipped my mind, give me a couple hours to rebuild context
On Sat, Nov 6, 2021, 12:39 Andres Vahter @.***> wrote:
It has been quiet, I guess concern with no-std-net is not yet solved?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/newAM/w5500-hl-rs/issues/14#issuecomment-962492918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIN7SZPF5ACJZXNNVLMRK3UKVY6ZANCNFSM4YH7DYQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Alrighty, sorry for dropping the ball on that, should be taken care of https://github.com/rust-embedded-community/meta/pull/14
Guess this died out again? @eldruin @dunmatt
Alright, I have invited @dunmatt now to the r-e-c org. Once you accept, you can transfer the repository. Thanks for the heads up @MathiasKoch.
Any update on moving no-std-net to r-e-c?
The RFC for networking types in core got merged, looks like it won't take much longer for implementation.
Small update on this, the ip_in_core feature is available on nightly, and I added support for it in #245.
I opened a PR to add ip_in_core support to embedded-nal: https://github.com/rust-embedded-community/embedded-nal/pull/81