Nic Cope
Nic Cope
@ezgidemirel Two other small nits I noticed that aren't related to this PR specifically. It's fine to address them separately: * `MRStateRecorder` takes a `client.Client`, but only reads. It could...
Converting to draft because I forgot I had to update all the uses in _this_ repo. 😆
I'm not sure this is something we want to support. Today, Crossplane is designed to allow you to compose Crossplane managed resources (MRs). This is an intentional constraint. The consistent...
Thanks for spotting this @sttts. At first glance I agreed with your assessment, but after digging a little deeper I think we're okay. Or more specifically, I don't think we're...
Does a resource being updated mean it's not ready? I don't think so, at least not usually. The `Ready` status condition indicates that the resource in the external system that...
Assigning myself - I'd like to make some time to review before we proceed here. This reconciler is very subtle and very widely used.
> Maybe merge errors that we report under Synced into Ready condition? i.e. look at Ready condition for all kinds of errors we are able to report? This sounds like...
From @hasheddan on https://github.com/crossplane/crossplane/pull/1721: > I wonder if we could just confine synced to resources that talk to APIs outside of the cluster? I think it's appropriate to remove Synced...
@displague I'd still like to deprecate it but I haven't yet had time to find out whether folks are onboard - I could imagine it might be a bit controversial....