crossplane-runtime icon indicating copy to clipboard operation
crossplane-runtime copied to clipboard
verified publisher icon crossplane

Mark test.EquateErrors as deprecated

Open negz opened this issue 2 years ago • 3 comments

Description of your changes

We can't remove this (it would be a breaking API change) but I want to discourage and redirect folks.

See https://github.com/crossplane/crossplane/issues/4514 for context and more discussion. I've also updated this repo to follow the new pattern proposed in that issue, so it acts as an example of how tests might look if we choose to adopt it.

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

negz avatar Aug 24 '23 18:08 negz

Converting to draft because I forgot I had to update all the uses in this repo. 😆

negz avatar Aug 24 '23 18:08 negz

This is approved, so if this PR is still relevant could we rebase and merge?

lsviben avatar Sep 03 '24 08:09 lsviben