crossplane-runtime icon indicating copy to clipboard operation
crossplane-runtime copied to clipboard

Not all references support `resolve` and `resolution`

Open negz opened this issue 2 years ago • 4 comments

What happened?

https://github.com/upbound/provider-aws/blob/6075caef/package/crds/aws.upbound.io_providerconfigusages.yaml#L52

We added these new fields in https://github.com/crossplane/crossplane-runtime/pull/328. I believe the intention was to affect only cross-resource references. Unfortunately the PR added the fields to generic reference types that are used in many places in Crossplane - for example in the ProviderConfigUsage above.

I believe this means we now have a few reference fields in Crossplane that expose resolve and resolution fields that don't actually do anything. This is a poor user experience - since anyone looking at the API docs might find them and think they can use them.

I would suggest we either:

  • Remove these fields where they're not used.
  • Make sure they work everywhere that they exist.

negz avatar May 15 '23 22:05 negz

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] avatar Sep 03 '24 09:09 github-actions[bot]

/fresh

negz avatar Sep 12 '24 19:09 negz