Nic Cope

https://kpt.dev/reference/schema/crd-status-convention/ More prior art - looks like the kpt folks recommend something similar.

I'll move this over to crossplane-runtime, since that's where the ProviderConfig reconciler lives. Sounds like this is hard to repro, but if it happens again I'd be curious to know:...

CC @turkenh :)

It doesn't sound like omitting omitempty goes against conventions: > In most cases, optional fields should also have the omitempty struct tag (the omitempty option specifies that the field should...

@hasheddan Are you confident it won't have any negative side-effects/behaviour changes? If so I'm okay with it.

https://github.com/kubernetes-sigs/cluster-api/issues/707 Some more prior art here. Having swapped back in the context of this issue I think we're on the right path. I'm not sure if we want to _completely...

https://crossplane.slack.com/archives/CKXQHM7U3/p1581113468101800 https://play.golang.org/p/NnWsj9BaTeJ https://play.golang.org/p/oxQgQxtWK62 Cross-linking some discussion from Slack. I actually now think our late init code is ~working as expected~ a little broken when it comes to late-initializing an unspecified...

I think the two external issues relating to `omitempty` that were linked in this issue were red herrings, because they deal with fields that are slices (not pointer to slices).

> I'll start with moving Update call above Delete Another option to consider here would be to change the current `if meta.WasDeleted(managed)` condition to `if meta.WasDeleted(managed) && observation.UpToDate`. At first...

I believe so! CC @muvaf who may have an opinion here.