Virtually Nick

Results 270 comments of Virtually Nick

It will eventually correspond to apache/guacamole-server#467, once I figure out how to fix that one.

Just one other comment on how various clients behave: * Windows: Browsing from Windows explorer to this share results in the intended behavior - seeing the contents of the `share1\`...

> > Just one request - `#define` things that should be constants. > > Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?...

> > > > Just one request - `#define` things that should be constants. > > > > > > > > > Shouldn’t I rather follow the existing style...

> > @necouchman, @jmuehlner, have you any other comments on this PR? > > It's looking pretty good to me - though I do wonder if it should be targeted...

@NickVStepin I see you updated pull request title, but commit messages also need to be 1) updated to include "GUACAMOLE-925:" prefix, and 2) should be descriptive of the changes.

@NickVStepin : You can do the following: * Use "git log" to find the commit ID of the commit *before* your first commit. * Use "git rebase -i " to...

I'll also add that a nice-to-have would be output to systemd-journald-remote, in the journald format, which has largely supplanted syslog on newer Linux distributions.

@darkman97i Do I read correctly that this means you do not intend to provide a Community Edition going forward? Maybe you could update your web page and indicate that, or...

@samirchahine: Thank you for the contribution. Please follow the format used throughout other contributions for the pull request title and the commit messages. This should have the JIRA issue prepended...