Virtually Nick

Results 268 comments of Virtually Nick

@akallabeth: If you split up the commits into separate JIRA issues, then you need to open pull requests for each JIRA ticket - both the pull request and the commits...

This looks okay to me, but I'm not confident in my ability to review the configure.ac changes. @mike-jumper anything that needs to be fixed before this one goes in?

@madmath03: Please note that all your commits need to have the "GAUCAMOLE-124" tag on them. Also, might want to consider squashing the commits into a smaller number - five is...

> Despite Guacamole otherwise having full control of the Esc key, that control is lost while in full screen. This is a bit annoying when using an application which leverages...

@depawlur: I don't think it's dead, just didn't get finished up in time to make the 1.3.0 release. Hopefully we can add it to the next one...

@madmath03: > For the point 1 though, I do not agree with you. It's actually not related to the current page since it switches the whole browser to fullscreen mode....

@mike-jumper Any further thoughts or guidance on placement of this item? @madmath03 Fair point about the non-desktop browsers, this makes sense. Let's see if we can reach consensus on where...

@oxcrag There is still a merge conflict, here, and you have two commits with the same commit message. These commits should either be squashed together, or given meaningful messages.

@cmosguy: Thank you for the contribution. Before we go further, though, please create a JIRA issue for this and tag both the pull request and the commit messages with the...

While I generally lean toward using `JOIN` instead of nested queries in SQL, and I'm skeptical of situations like this, I _think_ this actually makes sense - it is pre-sorting...