Virtually Nick
Virtually Nick
> Are there any changes needed to be made to the webapp to leverage these constants? I did not find any references to the old constants: ``` $ find guacamole/src/main/frontend/src/...
Aha! Okay, I've added another commit that updates the `ManagedClient.js` file to use the new enum values.
@mmezog See Mike's feedback. If you can respond and/or update, I'd like to try to include these updates in the next release.
Okay, fixed a few things up and made some of the requested changes. Let me know how it looks, now.
I may end up closing this PR and just redoing it - I tried to resolve the conflicts between current master and this PR, and it was feeling a little...
Okay, @mike-jumper, I've reworked this on top of the existing master, so I think it's good, now...
I reworked the proxy attributes from LDAP as you suggested, but came across a couple of things: * I used the `INTEGER` syntax for the `guacProxyPort` attribute, but it's unclear...
@mike-jumper: > Doesn't this just mean that pkg-config needs to be installed for the PKG_CHECK_VAR macro to be defined? As @knacktim mentioned, no, this isn't just the presence of pkg-config,...
Yep, that would work. I also stumbled across this solution from someone in a completely different project: https://git.sagemath.org/sage.git/commit?id=16a0a75c66a2e05187e174f3336edd525c65bb41 They wrote a M4 macro to do what `PKG_CHECK_VAR` does...
@iljavs Thank you for the contribution. You'll need to create a JIRA issue for this and tag the pull request and the commit messages with the JIRA issue. See other...