guacamole-server icon indicating copy to clipboard operation
guacamole-server copied to clipboard

Published 20 hours ago • verified publisher icon apache

GUACAMOLE-925: Patch add russian keyboard

Open NickVStepin opened this issue 10 months ago • 3 comments

NickVStepin avatar Apr 16 '24 08:04 NickVStepin

@NickVStepin I see you updated pull request title, but commit messages also need to be 1) updated to include "GUACAMOLE-925:" prefix, and 2) should be descriptive of the changes.

necouchman avatar Apr 26 '24 13:04 necouchman

Thanks @NickVStepin! A couple of minor updates requested, here, and one thing that I'd like Mike's feedback on.

Also, the title of the Pull Request, as well as the commit message(s) should contain the GUACAMOLE-925: prefix - see the other PRs for examples of that.

Thanks @necouchman. Sorry, i don't change prefix my commit messages. :( Should I create new commit messages?

NickVStepin avatar Apr 27 '24 05:04 NickVStepin

@NickVStepin : You can do the following:

  • Use "git log" to find the commit ID of the commit before your first commit.
  • Use "git rebase -i " to start an interactive rebase.
  • Use the "reword" option on each of the commits.
  • Change the commit messages.
  • Force-push the changes, which will automatically update this pull request.

necouchman avatar Apr 27 '24 11:04 necouchman