guacamole-server icon indicating copy to clipboard operation
guacamole-server copied to clipboard

Published 20 hours ago • verified publisher icon apache

Minor Freerdp api fixes

Open akallabeth opened this issue 4 years ago • 3 comments

Found some issues during testing, feel free to use/modify/... these.

akallabeth avatar Oct 04 '21 12:10 akallabeth

Thanks, @akallabeth.

We don't normally cover multiple JIRA issues with a single PR. If these changes are distinct enough that they warrant three separate JIRA issues, the changes for those separate issues should also be separate PRs.

Do you think it makes sense for these changes to be covered by a single issue? Or do you think it's best to split these changes? I would personally be OK with either.

mike-jumper avatar Oct 08 '21 18:10 mike-jumper

@mike-jumper I thought it would be best to have one issue per commit? Can split it if you prefer that.

akallabeth avatar Oct 11 '21 06:10 akallabeth

@akallabeth: If you split up the commits into separate JIRA issues, then you need to open pull requests for each JIRA ticket - both the pull request and the commits should only be associated with a single JIRA issue. Up to you - we'll review it however you submit it, just seems like it would be easier to group them together in both a single JIRA issue and a single pull request.

necouchman avatar Oct 11 '21 11:10 necouchman