Nicholas Blumhardt

Results 455 comments of Nicholas Blumhardt

Thanks for the note. It should be rare to see an exception caught at this point; just for some context, could you share some info about the error that prompted...

Thanks for the follow-up! The proposal is reasonable; I wonder if we could make the output a little nicer using `ExceptionDispatchInfo` 🤔 ```csharp using System.Runtime.ExceptionServices; A(); static void A() {...

Prints: ``` PS C:\Development\temp\stack> dotnet run Yada yada: System.Exception: Failed ---> System.NotImplementedException: The method or operation is not implemented. at Program.g__C|0_2() in C:\Development\temp\stack\Program.cs:line 24 at Program.g__B|0_1() in C:\Development\temp\stack\Program.cs:line 14 ---...

Also probably fine to improve the diagnostic experience for .NET 5+ and simply leave the current experience for the earlier frameworks, if it's simpler 🤔

@penenkel perhaps we move this over to the `serilog/serilog` repository - I'll transfer it now (whatever we do here, we'll more than likely do over there).

Hmm, yes, you're probably right, there. Shall we get a PR going, in this repo, to push it along a bit?

Most likely no; I think: https://github.com/serilog/serilog/blob/1aabe1d6bde10382233fb2a50e0e2c6e0c9b8287/src/Serilog/Capturing/PropertyValueConverter.cs#L360 is closer. It needs a bit of experimentation and testing, though - a list of specific inputs we really care about capturing call site...

Hi @mariopasquali, thanks for the well-considered issue 👍 I think it might be reasonable to consider this a bug - padding should probably still apply even when no value is...

Thanks for the follow-up, Mario, and sorry I missed replying to the second part of your message. The goal of Serilog's template syntax is to be/remain as close as possible...

Hi Mario - regarding how to maintain compatibility with existing sinks, all of the text-based sinks accept an `ITextFormatter` that is responsible for rendering out events as text. The default...