Nicholas Blumhardt

Results 455 comments of Nicholas Blumhardt

Hi @jods4 - not sure we're on the same page, I might not have been very clear in my reply. > The problem with file sink is that you can't...

Unless someone beats me to it, I'll try to find some time in the near future to run through the code and figure out what's required. It would be very...

Hi Maciej! Thanks for jumping in. Before your questions, just some brief commentary on those missing params: ```csharp // Not sure about this one, think it's good for auditing 👍...

Hi @maciejw - thanks for the update. Regarding the consistency of construction, and checkpointing open/close issue, it'd be great to explore and potentially address those as separate PRs, since including...

Thanks for the ping, @jods4! I'm not sure about the final state of the PR - IIRC there was still some work to do. Paging that back in now could...

What you have there looks right to me; guessing the flakiness is in the workings of the I/O stack (.NET and OS), which can be tricky at times (buffers/flushing/caching of...

Hi, thanks for your message. Not sure about the first question, may be one for Stack Overflow as it's likely someone's had this need in the past, nothing I can...

Tricky! I'd be wary of changing the open flags, at least without spending some time re-validating the atomic append functionality and concurrent-burn-testing it (https://nblumhardt.com/2016/08/atomic-shared-log-file-writes/ ). My instinct says changing flags...

Nothing happening in the short-term on this; forking and modifying for your needs will be the quickest way forward for now, sorry.