Nicholas Blumhardt
Nicholas Blumhardt
Hi @DarkMio; v5.2.0 is out now and includes this fix. I'll close the ticket as completed but if you notice any ongoing issues please let us know!
Ah sorry, also, for this to work you'll need to asynchronously dispose the Serilog `Logger`. If you're `using var logger = new LoggerConfiguration().CreateLogger()` that maps to `await using`; otherwise, using...
Thanks for the PR! This seems like it would cause significant pain downstream - many consumers of this package use `loggingBuilder.AddSerilog()` - any thoughts on how that should be handled?
@dkattan thanks for the ping. I think the tracking issue on the Serilog side is https://github.com/serilog/serilog-sinks-file/issues/135 - will centralize discussion there.
@stphnlwlsh a separate PR that addresses the dependency version only would be welcome - this PR is unlikely to move forward at this point due to the potential for breaking...
Thanks! I think all of the threading of the level through the various pieces is solid. I don't think we need to bake the idea of a "line style" into...
Closing this one as stale, but if the OP or anyone following along is keen to follow up - I left some comments originally above; I think in order to...
This could be a bit problematic for things like: ```csharp Account from; to; Log.Information("Transferring {Amount} from {From} to {To}", 100, from, to); ``` Seems like the hit rate for this...
Thanks for the note; this rings a bell - needs some investigation to see what the trade-offs are, but on the surface it looks like a simple bug fix is...
That's an excellent idea, thanks - if it had been suggested early on, we'd have made this the default, I think. We still might want to consider changing the default,...