Nicholas Blumhardt
Nicholas Blumhardt
Hi @HeartofTheForce - I notice you closed your PR; thanks for the help all the same! I'll mark this as up-for-grabs, let me know if you are interested in picking...
Thanks for the thoughts Ben! For completeness we should probably also consider that adding a generic `failoverTo:` capability to all Serilog sinks would be better overall for the ecosystem, though...
Another might be introducing `Task IBatchedLogEventSink.Emit(LogEvent[] events)` somewhere, and having the sinks implement that. Failures could be propagated per batch via the task's `ContinueWith()`, thus supporting the chaining from one...
Hi @kevingates! `IBatchedLogEventSink` now exists in _Serilog.Sinks.PeriodicBatching_, and I think we're happy enough with the shape of it that it could move to _Serilog_ if needed: https://github.com/serilog/serilog-sinks-periodicbatching/blob/dev/src/Serilog.Sinks.PeriodicBatching/Sinks/PeriodicBatching/IBatchedLogEventSink.cs There's no official...
Thanks for the suggestion, Todd - makes perfect sense :+1: There are a few moving parts to this; Seq uses `Serilog.Formatting.Compact.CompactJsonFormatter` to format its payloads: https://github.com/serilog/serilog-sinks-seq/blob/3152e1d59fbbbc07ea97f3f3cba3e48914659a8b/src/Serilog.Sinks.Seq/Sinks/Seq/SeqPayloadFormatter.cs#L40 `CompactJsonFormatter` renders any message...
Alongside this, adding support for NLog (4.5+) would also be interesting to discuss. Just remembered about this issue while reading https://github.com/NLog/NLog.StructuredEvents/issues/46. (CC @304NotModified.)
Also- LibLog, which supports message template syntax too.
:+1: this would be nice
@Balfa 👋 Having a consistent convention makes it more pleasant to read logs created by multiple developers; the details of the convention itself are mostly just opinion. I'm pretty sure...
Thanks for the suggestion! There's no mechanism to include that information in the current version, but I think it would be useful to add 👍