nathanfranke

"Required toolchain not found for platform" printed instead of more helpful errors such as "ANDROID_NDK_ROOT not set".

2

I wanted to build my extension for Android, so I casually ran `scons p=android` assuming it would tell me what's wrong. Instead I got "Required toolchain not found for platform"....

To implement, would be similar to https://github.com/godotengine/godot/pull/44949

~~See https://github.com/godotengine/godot/pull/62870 (not merged yet)~~ ~~Superseded by https://github.com/godotengine/godot/pull/63049, I will update this PR once merged~~

Update Complying with Licenses page

11

- Clarify that it is not legal advice. - Remove outdated third-party attributions, and point them to COPYRIGHT.txt instead.

I think this was hinted at in #9 and implemented in https://github.com/Valeryn4/Godot-IOS-Services-Extend-Module/blob/master/iosservicesextend/ios/src/SKExtend.mm Documentation: https://developer.apple.com/documentation/storekit/skstorereviewcontroller/2851536-requestreview CC @Valeryn4 since they might know more about this than me.

## Before:  ## After: 

fix: don't pass callback as metadata when omitted

3

## Changes If `callback` is passed but not `metadata`, reset `metadata`. ## Verification I changed this code manually on my generated files and it works exactly as expected.

Add package manager instructions if available on Linux

1

**Operating system, Browser, Browser Version:** Linux 5.18.11-arch1-1 Mozilla Firefox 102.0.1 **Issue description:** Package manager commands should be included as Godot can be updated "automatically" with the rest of the system....

New links for unreasonably long videos (even if they have timestamps)

6

I've had some issues when trying to automatically download all videos. For example, on [mn-minneapolis-28](https://github.com/2020PB/police-brutality/blob/master/reports/Minnesota.md) there is a [link to a two hour long YouTube video](https://www.youtube.com/watch?v=XAa5xb6JitI). While there is a...

## Bug Description I crafted the ultimate sandwich, but the achievement was not awarded. The issue is that the NBT of my item has an extra entry `Depth`. ```diff -...