ts-protoc-gen icon indicating copy to clipboard operation
ts-protoc-gen copied to clipboard

Published 20 hours ago • verified publisher icon improbable-eng

fix: don't pass callback as metadata when omitted

Open nathanfranke opened this issue 3 years ago • 3 comments

Changes

If callback is passed but not metadata, reset metadata.

Verification

I changed this code manually on my generated files and it works exactly as expected.

nathanfranke avatar Jan 13 '22 00:01 nathanfranke

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign marcuslongmuir You can assign the PR to them by writing /assign @marcuslongmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

improbable-prow-robot avatar Jan 13 '22 00:01 improbable-prow-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 05:04 stale[bot]

Still desired

nathanfranke avatar Apr 16 '22 07:04 nathanfranke