Nathan V. Morrical comments

Results 67 comments of


                                            Nathan V. Morrical

trafficstars

memory leaks on windows when using tinyobj_loader_opt.h

Hi @syoyo, Thanks for the quick response! There still appear to be several vectors still using lfpAlloc, and so I'm still leaking memory in Windows. If you remove this line,...

memory leaks on windows when using tinyobj_loader_opt.h

Huh, the problem actually might go deeper than lfpAlloc... lfpAlloc definitely leaks the most memory, but there appear to be other leaks as well, so it might not be lfpAlloc...

[SPIR-V] Presence of vk::RawBufferLoad turns RWStructuredBuffer into AppendConsumerBuffer

I'm out of my element, but have also been looking into using vk::RawBufferLoad. I wonder if this is because using the "SPV_KHR_physical_storage_buffer" and the PhysicalStorageBufferAddresses capability promotes the addressing model...

[SPIRV] Incorrect error reported for non uint type template parameter: "error: alignment argument of vk::RawBufferLoad() must be a constant integer"

It seems like the solution to this could be to just change the compiler error message to “alignment argument of vk::RawBufferLoad() must be a constant unsigned integer” Am I understanding...

Multiple -entry options in single slangc invocation does not work

Hey Jonathan! if this is unsupported then the -h output for slangc should probably be changed. At the moment it states that multiple entry points are allowed on the same...

Multiple -entry options in single slangc invocation does not work

Thanks for the response! A bit more background, we generally lean towards using slangc, as for this project we prefer not to ship raw shader code with the executable. It's...

[SPIR-V] Feature request: use "uniform" syntax to access SBT record data in ray tracing workflows

I wonder if the RawBufferLoad functionality described here could work as a workaround? https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/SPIR-V.rst#rawbufferload Update, yes, this seems doable using vk::RayBufferLoad.

[SPIR-V] Feature request: use "uniform" syntax to access SBT record data in ray tracing workflows

Update, seems that the "uniform" syntax I'm used to with slang doesn't work with HLSL RT -> Vulkan. Is this a bug? The [[vk::shader_record_ext]] with a ConstantBuffer appears to work.

[SPIR-V] Feature request: use "uniform" syntax to access SBT record data in ray tracing workflows

I was largely confused between the differences with slang-shader's flavor of HLSL and DXC. I thought in the case of multiple entry points that only one ConstantBuffer with [[vk::shader_record_ext]] could...

Example demonstrating how to use SBT record data in a ray tracing pipeline

Hi Sascha, Let me know if there's anything you'd like me to add to the example. I'm thinking I might also submit a PR also demonstrating how to use custom...