Nate Prewitt

Results 232 comments of Nate Prewitt

Thanks for the report, @bonastreyair! So I think this is on the edge of support. Headers have always been defined to be a `str` or `bytes` and we've been programmatically...

I wrote up a [patch](https://github.com/nateprewitt/requests/commit/66fcc9c88cf5a53e85322305f41006032744cbe3) for this on Friday. I've been waiting to see how widely this approach is used, because we've only had 4 reports with ~75% of downloads...

> Using enums for header names is a common (and generally regarded as a good) practice. +1. I don't believe anything in this change precludes the use of enums in...

Yeah, I agree we should just fix it. Long term, I'm in favor of us reworking cookies entirely, as we've discussed before. For the moment, this seems reasonably straight forward...

Thanks for confirming, @kianelbo. I have your PR on the shortlist for review this week and we'll look at getting this change added.

Hi @Alex8768765, Can you please provide the info we originally requested in the issue template? The header you're using isn't valid in the HTTP spec, so it seems unlikely this...

Hrmm, well that does pose a problem. While Requests only supports http/1.1, Hyper has been "compatible" for quite a while. I'll need to take a look at possible escape hatches....

After a cursory look, I don’t think we can escape this at the adapter level. The immediate fix is to use the PreparedRequest workflow in the Requests docs and set...

Hi @ArjunSharda, Thanks for the PR. Typically, we don't accept misc infrastructure changes without notable benfits. This is to reduce PR noise and avoid incomplete updates. In the future, we'll...

Hmm, so this appears to actually be a breakage introduced by this PR in urllib3 1.26.0. Requests is still forwarding the unencoded URL but [urllib3 now unilaterally enforces encoding](https://github.com/urllib3/urllib3/commit/691679f738ae098ce024aeae90cfdd8013b8e1e7#diff-2d5453550bf56a4666a88e9262248cea2f8ef2338695b5300b6c9a550647ee0eR631) on...