Nate Prewitt

Results 232 comments of Nate Prewitt

Hi @ondratu, Could you please clarify what you believe is wrong in this case? `ř` is the byte-sequence `\xc5\x99` in UTF-8, so we'd expect the bytes object to be `Ond\xc5\x99ej`....

Hmm, on closer inspection this does appear to be a bug. We're using the bytes username as an argument to [format our string](https://github.com/psf/requests/blob/2d5517682b3b38547634d153cea43d48fbc8cdb5/requests/auth.py#L215-L225) for the header. This causes the full...

Hi @stephen-goveia, this is a behavior in urllib3 as noted in urllib3/urllib3#2123. We aren't able to change it in Requests, so the outcome will be determined by whether this makes...

Hi @GiorgioComitini, thanks for bringing this to our attention. From what you've described above, I believe we can already tell this is an issue at the [PySocks](https://github.com/Anorov/PySocks) layer or potentially...

So that's pretty interesting if it's the same versions being used with Requests. The only socks specific code in Requests is [here](https://github.com/psf/requests/blob/79f60274f7e461b8fd2f579e741f748438d7eadb/requests/adapters.py#L181-L191). We create a copy of urllib3's SOCKSProxyManager and...

The quickest way to confirm that would be to set `trust_env` to False and see if the behavior goes away.

Hi @GiorgioComitini, Apologies for the delay. Yes, this is intended to be a Session-wide setting rather than per request. Either you trust the host or you don't. In general with...

Hi @frafra, this warning is a remnant from when Python 2 was still the main Python and `bytes`/`str` were synonymous. You'll see if you look at the definition for [`basestring`](https://github.com/psf/requests/blob/main/requests/compat.py#L79)...

Hi @ricellis, thanks for revisiting this. I don't believe we'll be seeing this removed in the near future until 3.0.0 is ready. If you'd like to make a small addendum...

Hi @krystofernewman, it doesn't sound like your issue is related to this one directly. We're specifically discussing simplejson's impact on `Response.json()`. There are likely similar issues on the `json` Request...