Nate Prewitt

Results 232 comments of Nate Prewitt

Hi @adamantoise, Thanks for reaching out! We're aware of the typo in the variable, but unfortunately, fixing it isn't straight forward. Due to the age of the variable, it's difficult...

Yeah, I think a brief comment callout is a reasonable suggestion. We'll leave this open to track that as a quick follow up item. Thanks again for reviving the conversation.

Not deleted, just hiding on the last "requested changes" comment thread šŸ˜‰

Just a bit more information on this. I upgraded to h2==2.5.0 today and my code using the `HTTP20Adapter` with requests stopped working. I went back and tested the current example...

This should now be resolved python-hyper/hyper-h2#382 on the master branch and available in hyper-h2's next release (2.6.0).

That's a good callout @njsmith, it looks like this may be fixed, but urllib3 hasn't cut a release in almost a year. I don't have time to move the original...

Went ahead and tested. I can't get this to work in Requests with the current urllib3 master, but that wasn't making sense. I made a [urllib3-only repro](https://gist.github.com/nateprewitt/d4df91be2f24cec7d7d531a82f7aa019) and it appears...

@njsmith, just to clarify, does h11 only reject sending headers with white space between the name and colon or receiving as well? I’m not sure if we want to hard-fail...

Hi @psyciknz, you'll need to use a [`DynamicInlineTableDict`](https://github.com/uiri/toml/blob/master/toml/decoder.py#L644) to get the desired behavior. `preserve` was originally intended for round tripping data from a toml file. If you want to create...

Hi @arrowkato, @ArtemBernatskyy is correct. This is a newly added function that is available on Github and will be present in the next release. If you're trying to use examples...