Kenjiro Nakayama
Kenjiro Nakayama
I tried to add extensions by using `PHP_INI_SCAN_DIR` like https://github.com/nak3/openshiftv3-php with customizing `*.ini`: ``` extension = /opt/app-root/src/lib/modules/tidy.so ``` However, it overwrites default extensiton `/opt/rh/php55/root/usr/lib64/php/modules`. What is the best way to...
We can overrides `spec.deployments.replicas` as: ``` apiVersion: operator.knative.dev/v1alpha1 kind: KnativeServing metadata: name: ks namespace: knative-serving spec: deployments: - name: webhook replicas: 3 ``` But it does not change the values...
Fixes https://github.com/google/autocxx/issues/478 This patch adds Bazel Integration. It can build: * `autocxx-*` libs/binaries - please see `BUILD` in the top directory. * `demo` - please see `demo/BUILD`. ,which follows the...
DomainMapping became Beta since Knative v0.24 and now it should be enough to move GA. To make it GA: * [x] Drop `v1alpha1` DomainMapping API * [ ] Add `v1`...
/area build Since upstream gorilla websocket changed `SetCloseHandler` to handle a returned error from `WriteControl()`: https://github.com/gorilla/websocket/blob/666c197fc9157896b57515c3a3326c3f8c8319fe/conn.go#L1166-L1168 serving's unit test `TestServerShutdown()` started failing as websocket does not return `CloseError`. We temporary...
## In what area(s)? /area networking ## What version of Knative? HEAD ## Steps to Reproduce the Problem ### 1. Deploy Knative with autoTLS. ``` istioctl install -y kubectl apply...
## In what area(s)? /area API ## Describe the feature As per configmap comment: https://github.com/knative/serving/blob/c91f8c43eb806fea4f6315d970f6d78e89a96d7c/config/core/configmaps/features.yaml#L46-L48 It says "probably Knative 1.10" but it is still disabled by default. I opened this...
Example: WORKSPACE: ``` load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "b8a1527901774180afc798aeb28c4634bdccf19c4d98e7bdd1ce79d1fe9aaad7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-1.4.1.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-1.4.1.tar.gz", ], ) load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` BUILD: ``` load("@bazel_skylib//rules:run_binary.bzl", "run_binary") sh_binary( name =...
/area API /kind cleanup Please refer to https://github.com/knative/pkg/pull/2755#issuecomment-1593590298 Upstream recommends that we should turn off it and use APF instead.
`ListenerConditionType` changed recently: we need to do a review and determine if we have tests for every relevant permutation of conditions and reasons covered at least once in our conformance...