serving Bump gorilla websocket to 1.5.1+

/area build

Since upstream gorilla websocket changed SetCloseHandler to handle a returned error from WriteControl():

https://github.com/gorilla/websocket/blob/666c197fc9157896b57515c3a3326c3f8c8319fe/conn.go#L1166-L1168

serving's unit test TestServerShutdown() started failing as websocket does not return CloseError. We temporary pin to gorilla websocket to 1.5.0 but should be fixed.

Please refer to https://github.com/knative/serving/pull/14588 for the error log.

Nov 07 '23 06:11 nak3

Working in progress https://github.com/gorilla/websocket/pull/863

Dec 01 '23 10:12 nak3

Ugh... https://github.com/gorilla/websocket/pull/863 was merged but there is still a log noise issue https://github.com/gorilla/websocket/issues/880 in 1.5.1...

Jan 31 '24 08:01 nak3

Thanks, we'll track https://github.com/gorilla/websocket/issues/880 then.

Jan 31 '24 08:01 ReToCode

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

Jun 03 '24 01:06 github-actions[bot]

/remove-lifecycle stale

Jun 03 '24 05:06 ReToCode