Kenjiro Nakayama

Results 69 comments of Kenjiro Nakayama

The version info: ``` $ kubectl version Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.4", GitCommit:"3cce4a82b44f032d0cd1a1790e6d2f5a55d20aae", GitTreeState:"clean", BuildDate:"2021-08-19T11:52:07Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"} $...

@praveenrewar I wonder your cluster didn't enable TTLAfterFinished https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/ ? It is a feature gate. I tested the kapp from the https://github.com/vmware-tanzu/carvel-kapp/tree/8e1d1f706da29d9f31e003dcf7a7a413f54de75e build.

> Job deployed successfully, Should kapp consider operation as succeeded ? Yes, I think so. > Job deployment failed, should kapp consider operation as Failure and terminate immediately or continue...

It is probably better to create a PoC against serving with this change? At least it will be easier to review.

Thank you. > Note: The default exporter reporting-period values are defined per backend [here](https://github.com/knative/serving/blob/0b09cdda41ac308ea586fc2d2c86af4a6d2f87d5/vendor/knative.dev/pkg/metrics/config.go#L218). Prometheus: 5min, opencensus 1min. If the user sets metrics.reporting-period-seconds the new attribute we introduce in this...

I understand. Thank you. (`request-metrics-reporting-period-seconds` vs `reporting-period-seconds` is bad for eyes, though :sweat_smile: ) So, this PR has changes, to be precise: 1. exposing `request-metrics-reporting-period-seconds` to set queue-proxy's reporting period...

/lgtm Alright, then LGTM. (though I think I don't have the power to merge it. :sweat_smile: )

Any news for this? I'm looking forward ti this feature :smile:

Hi @dinever Thank you for your explanation. I understand it. So, we should have one feature and one fix. In terms of feature, as you explained, it will be nice...

In any case, please feel free to close this report, if you would like. Or if you would like to track the feature/fix, I'm alright to leave this open.