Kenjiro Nakayama

Results 69 comments of Kenjiro Nakayama

Thank you so much Kauana and Dave. > Finally, a more generic observation around this entire feature is that when we enable it our own hello world image doesn't work....

/cc @dprotaso @evankanderson @psschwei @ReToCode @skonto If there is any objection to make DomainMapping GA or miss some process, please leave a comment.

Just in case. As per the attached feature track in https://github.com/knative/serving/issues/7748 , the requirement of the GA is: > Four releases have been cut since the Alpha milestone, no roadblocks...

Ah, okay. Then, the issues in GA column should be solved.

(Deleted my previous comment) We need to update v1.12 release note, which was already published? https://github.com/knative/docs/pull/5761/files#diff-12992d159bc1329670548661400eea0c1c297f55cdee53f2d2b0855e367f3743 I would like to avoid the change of previous release note as much as...

I'm sure the flake started before 1.20. I bumped 1.20 if the flake can be fixed or not after getting a ping on slack https://cloud-native.slack.com/archives/C04LMU0AX60/p1700061890467089 The change may be affected...

Today's github action does not hit the flake at all. * Serving repo - https://github.com/knative/serving/actions/runs/6934043757 I have tried 3 times on my repo but no error happened. * https://github.com/nak3/serving/actions/runs/6938581702 *...

> Well that is interesting. @nak3 your environment with GH actions should not be different, right? Yes, no different and actually it failed yesterday.

Working in progress https://github.com/gorilla/websocket/pull/863