Kenjiro Nakayama

Results 69 comments of Kenjiro Nakayama

We probably want to update the comment in `config-domain.yaml` - https://github.com/knative/serving/blob/release-1.7/config/core/configmaps/domain.yaml#L43-L46

/lgtm /hold Thank you! LGTM.

For the `example.com` in the following scripts: - `serving/test/config/autotls/certmanager/caissuer/generate.sh` - `serving/test/config/tls/generate.sh` We would like to test the TLS with the external domain so it is OK to keep `example.com`.

Thank you, Ramy! I think we have some points to be discussed. For example, I am thinking something likes these: For use-case: - Is there anyone else who wants/wanted to...

> a list of parallel items for networking WG to engage with upstream gateway-api on supporting TLS to upstream (backendRef) services. Upstream gateway-api is planning to support the TLS to...

Hi @MaharaJothi Thank you for reporting this. But could you please open the issue against [kubernetes-ingress-controller](https://github.com/Kong/kubernetes-ingress-controller) instead of here? There is one similar issue has been reported https://github.com/Kong/kubernetes-ingress-controller/issues/2543 though I...

I know only this one https://github.com/knative/serving/blob/main/docs/scaling/SYSTEM.md If you are looking for another docs I think it might be better to ask in Knative Slack channel or https://github.com/knative/docs

Yeah, `maxReplicas` has a bug in not only `spec.deployments.replicas` but also `spec.ha` (`ha.go`). I think we can apply the same fix with https://github.com/knative/operator/pull/748 to `spec.deployments.replicas`.

No, unfortunately https://github.com/knative/operator/pull/748 fixed the issue for `spec.ha` but `spec.deployments.replicas` still does not care about `maxReplicas` :cry: