Use svc.cluster.local as default domain

[psschwei]

trafficstars

Signed-off-by: Paul S. Schweigert [email protected]

Fixes #13182

Release Note

Uses the cluster domain suffix `svc.cluster.local` as the default domain. As routes using the cluster domain suffix are not exposed through Ingress, users will need to [configure DNS](https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#configure-dns) in order to expose their services (most users probably already are).  

/hold

[codecov[bot]]

Codecov Report

Base: 86.52% // Head: 86.49% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (13bed11) compared to base (19cd295). Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13259      +/-   ##
==========================================
- Coverage   86.52%   86.49%   -0.04%     
==========================================
  Files         196      196              
  Lines       14526    14526              
==========================================
- Hits        12569    12564       -5     
- Misses       1659     1663       +4     
- Partials      298      299       +1     

Impacted Files	Coverage Δ
pkg/reconciler/route/config/domain.go	100.00% <ø> (ø)
pkg/reconciler/revision/reconcile_resources.go	66.88% <0.00%> (-1.99%)	:arrow_down:
pkg/autoscaler/statserver/server.go	77.77% <0.00%> (-1.49%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[psschwei]

Need to wait on #13283 to run the kind e2e tests

[nak3]

We probably want to update the comment in config-domain.yaml - https://github.com/knative/serving/blob/release-1.7/config/core/configmaps/domain.yaml#L43-L46

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~config/OWNERS~~ [psschwei]
• ~~pkg/reconciler/nscert/OWNERS~~ [psschwei]
• ~~pkg/reconciler/route/OWNERS~~ [psschwei]
• ~~test/OWNERS~~ [psschwei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[nak3]

/lgtm /hold

Thank you! LGTM.

[nak3]

For the example.com in the following scripts:

• serving/test/config/autotls/certmanager/caissuer/generate.sh
• serving/test/config/tls/generate.sh

We would like to test the TLS with the external domain so it is OK to keep example.com.

[nader-ziada]

For the example.com in the following scripts:

• serving/test/config/autotls/certmanager/caissuer/generate.sh
• serving/test/config/tls/generate.sh

We would like to test the TLS with the external domain so it is OK to keep example.com.

Sgtm

[nader-ziada]

Need to wait on #13283 to run the kind e2e tests

this is merged, is this PR here ready to remove the hold?

[psschwei]

Not yet, we gave until Sept ~28~ 23 for anyone to comment on the mailing lists to changing the default domain

[psschwei]

Had no objections on the mailing list, so going to remove the hold on this tomorrow

[psschwei]

/hold cancel