Myk
Myk
> Hi! Is this done? If not I would like to take a shot The last comment on this bug is more than a year old. You are welcome to...
This definitely has potential. The cpp code is very ripe for testing. CTest seems perfectly fine for running the tests, but I think we need a better framework for *writing*...
Copied from discord so the questions don't get lost: So I guess there's a number of design decisions we need to make around cpp tests. Should they be 1 binary...
To answer your question in the description, it should be fine to replace BUILD_TESTS with BUILD_TESTING, but they'd need to exist in parallel at least for a while until CI...
> I'm not sure we need to decide up front whether it's monolithic or not. If we're using gtest + CTest, I think we can combine as many tests as...
bumping from project for now since the review isn't active. Once you're ready to take this up again, we can look into getting it merged!
@cppcooper is this the same issue you ran into? Do you remember what we did to fix the issue?
It looks like gcc 12.1 is too new for the GitHub build containers. Could you try adding -Wno-uninitialized to the json-cpp build command as in pbnoxious's patch? Does that get...
Labeling as a bug for now. @cppcooper can you tell whether this event should be firing? Is it possible to detect in adventure mode?
Burial receptacles are handled with the burial script, but I'm not aware of anything for beds. Beds are a little trickier, though, since there are more uses for beds than...